don't start template informer unless templateservicebroker is enabled #14579
Conversation
|
@smarterclayton can you confirm this was what you were looking for? |
pkg/cmd/server/start/start_master.go
Outdated
| @@ -464,7 +464,9 @@ func (m *Master) Start() error { | |||
| openshiftConfig.AppInformers.Start(utilwait.NeverStop) | |||
| openshiftConfig.AuthorizationInformers.Start(utilwait.NeverStop) | |||
| openshiftConfig.ImageInformers.Start(utilwait.NeverStop) | |||
| openshiftConfig.TemplateInformers.Start(utilwait.NeverStop) | |||
| if openshiftConfig.Options.TemplateServiceBrokerConfig != nil { | |||
There was a problem hiding this comment.
This isn't right - you should be avoiding the call to TemplateInformers.Template(). Start is already guarded by "has anyone asked for this informer yet".
|
tried and failed to be smarter than @smarterclayton - ptal and merge. |
jim-minter
force-pushed
the
guard_template_informer_start
branch
from
a26680f
to
fc5e181
Compare
|
Phenomenal lgtm [merge] thanks |
|
[Test]ing while waiting on the merge queue |
|
flake #13108 |
|
@knobuc router failed, may be network related or larger symptom https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2201/testReport/junit/(root)/Extended/_Conformance__networking__router__openshift_routers_The_HAProxy_router_should_override_the_route_host_with_a_custom_value/ |
|
[test] |
|
[merge][severity:bug] |
|
not sure how this tested success and then failed to merge, i guess it got conflicted by another PR: |
|
@jim-minter uhhh... that's extremely weird. meanwhile.... [test] |
|
@bparees think you can just re-hit merge |
|
@jim-minter ah hah. you caught the window. |
|
Evaluated for origin merge up to fc5e181 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1009/) (Base Commit: 84b8802) (Extended Tests: bug) (Image: devenv-rhel7_6362) |
|
Evaluated for origin test up to fc5e181 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2269/) (Base Commit: 84b8802) |
should resolve #8229 (comment), #14216 (review)
(also broken out TemplateInstanceControllerConfig into its own source file, didn't belong in apps.go)