Ensure protobuf serializations are stable across map order #14723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default maps were being serialized in random order, which broke guarantee that content wouldn't be mutated when saved. Fixed upstream and backported down.
smarterclayton
force-pushed
the
protostable
branch
from
f758a8c
to
229ee24
Compare
|
Evaluated for origin test up to 229ee24 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2367/) (Base Commit: 2d90d52) (PR Branch Commit: 229ee24) |
|
Upstream kubernetes/kubernetes#47701 I still need to verify the test is sufficient |
|
merged upstream, [merge][severity:bug] |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 3 |
|
Evaluated for origin merge up to 229ee24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant that
oadm migrate storagewas reporting secrets always changed (because they have maps).[test]