Move deployments to using versioned Kube informers #14728
Conversation
smarterclayton
force-pushed
the
move_deploys_to_versioned
branch
from
84b7f9f
to
6cf967b
Compare
smarterclayton
force-pushed
the
move_deploys_to_versioned
branch
from
6cf967b
to
1be5aeb
Compare
|
LGTM |
| } | ||
| } | ||
| if pod.Spec.Containers[i].Resources.Requests == nil { | ||
| pod.Spec.Containers[i].Resources.Requests = kapi.ResourceList{} | ||
| pod.Spec.Containers[i].Resources.Requests = v1.ResourceList{} |
There was a problem hiding this comment.
Where are you getting your pod from. There is defaulting on resource.Requests. Internal would always have run it. Does this path?
There was a problem hiding this comment.
This the whole "this isn't actually being used in admission" weirdness. This is called by a controller that has internal build and external pod.
There was a problem hiding this comment.
Actually creating a new pod.
|
|
||
| // ServiceServerCertificateExtension returns a CertificateExtensionFunc that will add the | ||
| // service UID as an x509 v3 extension to the server certificate. | ||
| func ServiceServerCertificateExtensionV1(svc *kapiv1.Service) crypto.CertificateExtensionFunc { |
There was a problem hiding this comment.
Why do we still have the old one?
| } | ||
| glog.V(4).Infof("Updated rollout status for %q from %s to %s (scale: %d)", deployutil.LabelForDeployment(deployment), currentStatus, nextStatus, deployment.Spec.Replicas) | ||
| glog.V(4).Infof("Updated rollout status for %q from %s to %s (scale: %d)", deployutil.LabelForDeploymentV1(deployment), currentStatus, nextStatus, deployment.Spec.Replicas) |
There was a problem hiding this comment.
deployment.Spec.Replicas needs to be dereferenced now
There was a problem hiding this comment.
It'll get printed correctly by fmt.
| func IsOwnedByConfig(deployment *api.ReplicationController) bool { | ||
| _, ok := deployment.Annotations[deployapi.DeploymentConfigAnnotation] | ||
| func IsOwnedByConfig(obj metav1.Object) bool { | ||
| _, ok := obj.GetAnnotations()[deployapi.DeploymentConfigAnnotation] |
Goal of eliminating duplicate internal and external caches when running in the controller by itself.
We are gradually moving to external clients for controllers, and this will remove the need to have separate caches for them.
Removes the need for an additional cache for these. Also all controllers are moving in this direction anyway.
smarterclayton
force-pushed
the
move_deploys_to_versioned
branch
from
1be5aeb
to
7d2ac22
Compare
|
Evaluated for origin test up to 7d2ac22 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2413/) (Base Commit: b0c0635) (PR Branch Commit: 7d2ac22) |
Part of #8229
Switches to the versioned caches and propogates using versioned code throughout deployment for pods and RCs. Leaves a few helpers pointing to internal to reduce test refactoring.
[test]