Build and ship ginkgo binary with extended tests #14839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use the `extended.test` binary we ship with the `-tests` RPM package, we need to also ship the `ginkgo` runner that is used to execute the tests. Signed-off-by: Steve Kuznetsov <[email protected]>
|
Why? For what cause?
|
|
You want to have one-stop shopping for: |
sdodson
approved these changes
Jun 22, 2017
|
[merge] |
|
[test] |
|
Evaluated for origin test up to 6ce1bad |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 1 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2727/) (Base Commit: 2f9d6cb) (PR Branch Commit: 6ce1bad) |
|
@openshift-bot, the last build failed from the following flakes:
re[merge] |
|
Evaluated for origin merge up to 6ce1bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use the
extended.testbinary we ship with the-testsRPMpackage, we need to also ship the
ginkgorunner that is used toexecute the tests.
Signed-off-by: Steve Kuznetsov [email protected]
/cc @johnbieren @sdodson @smarterclayton
[test]