Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended tests for DC ControllerRef #14880

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Jun 26, 2017

Test that DC controller adheres to Three Laws of Controllers.

cc: @mfojtik @Kargakis

@tnozicka
Copy link
Contributor Author

[test]

@tnozicka
Copy link
Contributor Author

tnozicka commented Jun 26, 2017

Fixes #14416

@tnozicka tnozicka requested a review from mfojtik June 26, 2017 13:35
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2017
@tnozicka tnozicka force-pushed the add-tests-for-rc-to-dc-controller-ref branch from 74b3b7d to 824f88b Compare June 27, 2017 07:18
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2017
@tnozicka tnozicka force-pushed the add-tests-for-rc-to-dc-controller-ref branch from 824f88b to 952ee3a Compare June 27, 2017 10:46
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 952ee3a

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2689/) (Base Commit: bbb9647) (PR Branch Commit: 952ee3a)

@tnozicka
Copy link
Contributor Author

prerequisite for #14907

@mfojtik
Copy link
Contributor

mfojtik commented Jun 27, 2017

LGTM [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 27, 2017

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 12

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 952ee3a

@smarterclayton smarterclayton merged commit 080fe59 into openshift:master Jun 27, 2017
@tnozicka tnozicka deleted the add-tests-for-rc-to-dc-controller-ref branch July 31, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants