Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: increase job re-list time in cronjob controller #14953

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 29, 2017

Partially addresses #14895 for 3.6 release. Proper fixes to the controller will happen in 3.7 release time frame.

@smarterclayton @mfojtik @pweil- up to you to decide

@soltysh
Copy link
Contributor Author

soltysh commented Jun 29, 2017

[test]

@mfojtik
Copy link
Contributor

mfojtik commented Jun 29, 2017

LGTM, green button merge this once it passes the test.

@smarterclayton
Copy link
Contributor

Panic in e2e, looks novel:


•! Panic [310.275 seconds]
[k8s.io] StatefulSet
/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:656
  [k8s.io] Basic StatefulSet functionality [StatefulSetBasic]
  /go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:656
    Should recreate evicted statefulset [It]
    /go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/statefulset.go:514

    Test Panicked
    runtime error: index out of range
    /usr/local/go/src/runtime/panic.go:458

    Full Stack Trace
    	/usr/local/go/src/runtime/panic.go:458 +0x243
    github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e.glob..func86.2.9()
    	/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/statefulset.go:434 +0x13ac
    github.com/openshift/origin/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc421040b40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    	/go/src/github.com/openshift/origin/test/extended/util/test.go:120 +0x3cf
    github.com/openshift/origin/test/extended.TestExtended(0xc42161ab40)
    	/go/src/github.com/openshift/origin/test/extended/extended_test.go:33 +0x40
    testing.tRunner(0xc42161ab40, 0x364b980)
    	/usr/local/go/src/testing/testing.go:610 +0x81
    created by testing.(*T).Run
    	/usr/local/go/src/testing/testing.go:646 +0x2ec

@0xmichalis
Copy link
Contributor

#15045 [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to b714f64

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2967/) (Base Commit: c9f829c) (PR Branch Commit: b714f64)

@smarterclayton smarterclayton merged commit d036fba into openshift:master Jul 5, 2017
@soltysh soltysh deleted the issue14895 branch August 3, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants