Improving the login layout when IE is in intranet mode

[rhamilto]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1298750

[jwforres]

@rhamilto if media queries are not supported that tells me even more of the console is broken than we realized, if you shrink things down to small desktop is it a mess?

[jwforres]

cc @spadgett

[spadgett]

@rhamilto Does adding

 <meta http-equiv="X-UA-Compatible" content="IE=edge"> 

to the document head help?

[jwforres]

ahhhh right that is how we forced the document mode

…

On Thu, Jul 6, 2017 at 1:24 PM, Sam Padgett ***@***.***> wrote: @rhamilto <https://github.com/rhamilto> Does adding <meta http-equiv="X-UA-Compatible" content="IE=edge"> to the document head help? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#15083 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZk7R9tWKBUhfZU1Tho02lyeb7Jax5fks5sLRhKgaJpZM4OP6ov> .

[rhamilto]

@spadgett, yep! That's the missing key. The login page does not have the meta element, but the rest of the console does. Will update the PR.

Is there a way for me to test the PR itself? I've been working off local files...

[spadgett]

You can try

$ OS_BUILD_ENV_PRESERVE="_output/local" hack/env OS_ONLY_BUILD_PLATFORMS="linux/amd64" WHAT=cmd/openshift make
$ hack/build-local-images.py origin
$ oc cluster up --version=latest

[jwforres]

@rhamilto so we actually have several other templates for the oauth server, and I guarantee they probably are ALL missing this line

[jwforres]

@liggitt FYI since this will be touching all of the oauth server's HTML pages (will wait for 3.7)

[spadgett]

This should be the first meta tag. Best to put it immediately after head.

[jwforres]

@rhamilto so @liggitt also has an oauth access granting page which isn't based off this same theme, but could still have issues, dont remember what the name of that file is offhand, maybe @deads2k knows?

[rhamilto]

@rhamilto so @liggitt also has an oauth access granting page which isn't based off this same theme, but could still have issues, dont remember what the name of that file is offhand

I think it's pkg/auth/server/grant/templates.go

I've searched the repo for the following and updated accordingly:

contain "data:image"

• pkg/auth/server/errorpage/templates.go [UPDATED]
• pkg/auth/server/login/templates.go [UPDATED]
• pkg/auth/server/selectprovider/templates.go [UPDATED]

contain "@media"

• cmd/cluster-capacity/go/src/github.com/kubernetes-incubator/cluster-capacity/* (documentation pages)
• examples/atomic-registry/allinone/registry-login-template.html [UPDATED]
• examples/atomic-registry/systemd/templates/registry-login-template.html [UPDATED]
• pkg/auth/server/errorpage/templates.go [UPDATED]
• pkg/auth/server/grant/templates.go [UPDATED]
• pkg/auth/server/login/templates.go [UPDATED]
• pkg/auth/server/selectprovider/templates.go [UPDATED]
• pkg/auth/server/tokenrequest/endpoints.go (not a full html file and only contains one rule--.nowrap)

I think we should be good.

[jwforres]

probably want to be careful about these whitespace changes, it might be affecting the final output

[jwforres]

[test]

[openshift-bot]

Evaluated for origin test up to 8d3eb02

[jwforres]

I think we might get a clean merge of this change with the existing OCP template overrides, so we may not need a separate PR for OCP

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2998/) (Base Commit: 289cf8f) (PR Branch Commit: 8d3eb02)

[liggitt]

LGTM

[smarterclayton]

Low risk, big win [severity:blocker] [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 3

[openshift-bot]

Evaluated for origin merge up to 8d3eb02