Support for PodPreset in get command #15148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liggitt
reviewed
Jul 11, 2017
| * poddisruptionbudgets (aka 'pdb') | ||
| * podpreset |
There was a problem hiding this comment.
should have been plural, but oh well
|
LGTM |
|
[merge][severity:blocker] |
|
[Test]ing while waiting on the merge queue |
|
@fabianofranz need to regenerate completions in a new commit |
|
Evaluated for origin test up to 1296f25 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3059/) (Base Commit: 1c8af8b) (PR Branch Commit: 1296f25) |
|
[merge][severity:blocker] |
|
Evaluated for origin merge up to 1296f25 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1275/) (Base Commit: 8dd73b5) (PR Branch Commit: 1296f25) (Extended Tests: blocker) (Image: devenv-rhel7_6439) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1449320
Cherry-picks kubernetes/kubernetes#44746
@liggitt need your approval, this fixes a blocker.