-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase to Docker Distribution v2.6.2 #15694
rebase to Docker Distribution v2.6.2 #15694
Conversation
/assign mfojtik |
/unassign |
Add support for custom routes and custom auth records per route.
….enter In some conditions, regulator.exit may not send a signal to blocked regulator.enter. Let's assume we are in the critical section of regulator.exit and r.available is equal to 0. And there are three more gorotines. One goroutine also executes regulator.exit and waits for the lock. Rest run regulator.enter and wait for the signal. We send the signal, and after releasing the lock, there will be lock contention: 1. Wait from regulator.enter 2. Lock from regulator.exit If the winner is Lock from regulator.exit, we will not send another signal to unlock the second Wait. Signed-off-by: Oleg Bulatov <[email protected]>
c5db3d1
to
e6bc3b6
Compare
flake #14772 |
/retest |
flake #15715 |
/retest |
flake #8571 |
/retest |
1 similar comment
/retest |
/test extended_image_registry |
@@ -0,0 +1,22 @@ | |||
The packages in this directory represent dependencies that differ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need this commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a brief description from 41f478a about why this vendor/ subdirectory exists and how one can recreate it. I found it useful when I was doing rebase. And yes, it another proof that we constantly loose changes related to distribution.
/approve we should get the extended registry test working before merging this. also we should consider fork_ami and give the QA something to test before merging as well? |
It seems the robot isn't going to wait for the green extended test, so I add the |
@dmage without lgtm label nothing is going to be merged. |
Fork ami is running at: https://ci.openshift.redhat.com/jenkins/view/All/job/ami_build_origin_int_rhel_fork/43/ |
Yes, these extended test are not merge-blocking today. Upstream issue: kubernetes/test-infra#3740 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, legionus, mfojtik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
flake #16025 |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/test extended_conformance_gce |
flake #16023 |
@dmage: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test extended_image_registry |
flake #12273 |
flake #14228 |
Automatic merge from submit-queue |
No description provided.