Consider openshift/origin-base a part of a release for pushing #15959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/XS
openshift-merge-robot
added
the
approved
|
/unassign |
|
/lgtm |
openshift-merge-robot
added
size/L
We are now depending on openshift/origin-base directly because of the new manner in which we are building images. We need to be pushing the base image as well as the component images to the hub. Signed-off-by: Steve Kuznetsov <[email protected]>
|
Whoops, pushed to this branch on accident. @smarterclayton I removed the commit |
stevekuznetsov
force-pushed
the
skuznets/update-push
branch
from
ec7b706
to
83cf05d
Compare
|
/lgtm |
openshift-merge-robot
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now depending on openshift/origin-base directly because of the
new manner in which we are building images. We need to be pushing the
base image as well as the component images to the hub.
Signed-off-by: Steve Kuznetsov [email protected]
/cc @smarterclayton