Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append user labels when --show-labels is passed #16053

Conversation

juanvallejo
Copy link
Contributor

Addresses BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1486501

--show-labels was not being honored when printing users with $oc get ...

cc @openshift/cli-review

@openshift-merge-robot openshift-merge-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2017
@fabianofranz
Copy link
Member

@juanvallejo just squash ;)

@juanvallejo
Copy link
Contributor Author

@fabianofranz thanks, done!

@fabianofranz
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2017
@juanvallejo
Copy link
Contributor Author

/retest

@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install_update

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16076, 16053, 16066, 16049, 16040)

@openshift-merge-robot openshift-merge-robot merged commit 9b6dfaf into openshift:master Sep 1, 2017
@juanvallejo juanvallejo deleted the jvallejo/append-user-labels branch September 5, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants