-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move the docker registry v1 client #16156
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Sep 5, 2017
openshift-merge-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Sep 5, 2017
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
deads2k
force-pushed
the
image-04-snip
branch
from
September 5, 2017 21:23
d382d87
to
97a98a1
Compare
deads2k
added
lgtm
Indicates that a PR is ready to be merged.
and removed
lgtm
Indicates that a PR is ready to be merged.
labels
Sep 5, 2017
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This client is only used in openshift code (not the dockerregistry itself) and appears to be related to v1 docker registries. I moved it under
pkg/images/importer/dockerv1client
.@mfojtik @bparees @soltysh This snips a link which is required to split the apiservers to avoid import problems. It also snips our last naughty depedency on pkg/dockerregistry.
I'd like to try to land this to land the image move.