Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 50334: Support iscsi volume attach and detach #16299

Merged
merged 1 commit into from
Sep 18, 2017
Merged

UPSTREAM: 50334: Support iscsi volume attach and detach #16299

merged 1 commit into from
Sep 18, 2017

Conversation

mtanino
Copy link
Contributor

@mtanino mtanino commented Sep 12, 2017

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2017
@openshift-ci-robot
Copy link

Hi @mtanino. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2017
@mtanino
Copy link
Contributor Author

mtanino commented Sep 12, 2017

[test]

@mtanino
Copy link
Contributor Author

mtanino commented Sep 12, 2017

/ok-to-test

@openshift-ci-robot
Copy link

@mtanino: you can't request testing unless you are a openshift member.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtanino
Copy link
Contributor Author

mtanino commented Sep 12, 2017

FYI:
This commit is a little different from commit on upstream because we can't backport iscsiInitiatorname API support(on upstream v1.8) to origin v1.7 tree.

@rootfs
Copy link
Member

rootfs commented Sep 12, 2017

See #15725
This will remove the exec changes.

@rootfs
Copy link
Member

rootfs commented Sep 12, 2017

cc @jsafrane

@rootfs
Copy link
Member

rootfs commented Sep 12, 2017

/approve

@mtanino mtanino changed the title UPSTREAM: 50334 : Support iscsi volume attach and detach UPSTREAM: 50334: Support iscsi volume attach and detach Sep 12, 2017
@rootfs
Copy link
Member

rootfs commented Sep 12, 2017

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2017
@eparis
Copy link
Member

eparis commented Sep 12, 2017

/approve
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2017
@mtanino
Copy link
Contributor Author

mtanino commented Sep 12, 2017

Waiting the #15725 gets land.

@eparis
Copy link
Member

eparis commented Sep 18, 2017

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2017
@eparis
Copy link
Member

eparis commented Sep 18, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, mtanino, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@rootfs
Copy link
Member

rootfs commented Sep 18, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16226, 16377, 15766, 16299, 16153)

@openshift-merge-robot openshift-merge-robot merged commit 0148eef into openshift:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childsb childsb Awaiting requested review from childsb

@eparis eparis Awaiting requested review from eparis

@humblec humblec Awaiting requested review from humblec

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@pmorie pmorie

@jsafrane jsafrane

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mtanino @openshift-ci-robot @rootfs @eparis @openshift-merge-robot @pmorie @jsafrane