Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdn: disable hostports when CRI-O is used #16463

Merged
merged 1 commit into from
Sep 26, 2017

Commits on Sep 20, 2017

  1. sdn: disable hostport handling when CRIO is used

    This is a workaround because CRIO's CNI driver has different
    hostport behavior than Kubernetes' CNI driver.  Kube leaves all
    hostport handling to the CNI plugin itself, while CRIO does
    hostport handling internally, leading to duplicate work if the
    plugin also handles hostports.
    
    For now, detect the runtime based on socket path and disable
    openshift-sdn hostport handling if the runtime is CRIO.
    
    The real fix for this is to add hostport handling to Kube's CNI
    driver, but in the "split" mode discussed upstream where kube's
    CNI driver handles the port reservations on the host, while the
    plugin handles the actual iptables rules.  CRIO should be converted
    to this scheme as well, and plugins will indicate with capabilities
    in the CNI JSON whether they support this scheme or not.  At
    that point we can remove this hack and just have openshift-sdn
    advertise portmapping support via the CNI JSON.
    dcbw committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    59b2b62 View commit details
    Browse the repository at this point in the history