Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create template-service-broker subpackage and image #16638

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Oct 2, 2017

My intent is to create the image in this PR too but I'm having trouble getting origin built at all right now.

++ Building go targets for linux/amd64: images/pod cmd/dockerregistry cmd/gitserver vendor/k8s.io/kubernetes/cmd/hyperkube pkg/network/sdn-cni-plugin vendor/github.com/containernetworking/cni/plugins/ipam/host-local vendor/github.com/containernetworking/cni/plugins/main/loopback examples/hello-openshift
can't load package: package github.com/openshift/origin/pkg/network/sdn-cni-plugin: cannot find package "github.com/openshift/origin/pkg/network/sdn-cni-plugin" in any of:
        /usr/lib/golang/src/github.com/openshift/origin/pkg/network/sdn-cni-plugin (from $GOROOT)
        /home/rdu/sdodson/go/src/github.com/openshift/origin/pkg/network/sdn-cni-plugin (from $GOPATH)
[ERROR] PID 7568: hack/lib/build/binaries.sh:228: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${OS_OUTPUT_PKGDIR}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"` exited with status 1.
[INFO]          Stack Trace: 
[INFO]            1: hack/lib/build/binaries.sh:228: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${OS_OUTPUT_PKGDIR}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" "${nonstatics[@]}"`
[INFO]            2: hack/lib/build/binaries.sh:158: os::build::internal::build_binaries
[INFO]            3: hack/lib/build/binaries.sh:141: os::build::build_binaries
[INFO]            4: hack/build-cross.sh:75: os::build::build_static_binaries
[INFO]   Exiting with code 1.
[ERROR] PID 7462: hack/lib/build/binaries.sh:152: `local -a binaries=("$@")` exited with status 1.
[INFO]          Stack Trace: 
[INFO]            1: hack/lib/build/binaries.sh:152: `local -a binaries=("$@")`
[INFO]            2: hack/lib/build/binaries.sh:141: os::build::build_binaries
[INFO]            3: hack/build-cross.sh:75: os::build::build_static_binaries
[INFO]   Exiting with code 1.
error: Bad exit status from /var/tmp/rpm-tmp.uQabdB (%build)

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2017
@deads2k
Copy link
Contributor

deads2k commented Oct 4, 2017

@sdodson looks to be building here

/retest

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2017
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 5, 2017
@sdodson sdodson changed the title [WIP] Create template-service-broker subpackage Create template-service-broker subpackage and image Oct 5, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2017
@sdodson
Copy link
Member Author

sdodson commented Oct 6, 2017

@deads2k should be good to go, need to get process started on internal release management stuff.
/retest

@sdodson
Copy link
Member Author

sdodson commented Oct 6, 2017

/retest

@deads2k
Copy link
Contributor

deads2k commented Oct 10, 2017

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sdodson

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2017
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2017

@sdodson: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/origin/unit 7e01869 link /test origin-ut
ci/openshift-jenkins/integration 7e01869 link /test integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16737, 16638, 16742, 16765, 16711).

@openshift-merge-robot openshift-merge-robot merged commit f8bbb7a into openshift:master Oct 10, 2017
@deads2k
Copy link
Contributor

deads2k commented Oct 11, 2017

@sdodson @stevekuznetsov What's the next step to get the image to appear here: https://hub.docker.com/u/openshift/ ?

@sdodson
Copy link
Member Author

sdodson commented Oct 11, 2017

@smarterclayton looks like we broke the push_origin_release job https://ci.openshift.redhat.com/jenkins/job/push_origin_release/1480/consoleFull#9597313135898c58db7602c31c0eab717 can you get that repo created in docker hub?

@sdodson sdodson deleted the tsb-subpackage branch May 11, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants