Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 48033: Refactor and simplify generic printer for unknown objects #16892

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Oct 16, 2017

Adds default table handler to the humanreadableprinter.
Fixes printer output for resources without a printHandler.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1455115

cc @openshift/cli-review @smarterclayton @deads2k

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 16, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 16, 2017
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2017
@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2017

@juanvallejo this looks like a pick of a particular PR in kube. We name those commits UPSTREAM: <number>: <description>

@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2017

Also, was the pick clean?

@juanvallejo juanvallejo changed the title bump(k8s.io/kubernetes): 6bd0c38908daed2d4e59a3b2540d3f0564f87068 UPSTREAM: 48033: Refactor and simplify generic printer for unknown objects Oct 17, 2017
@juanvallejo juanvallejo force-pushed the jvallejo/bump-humanreadable-printer branch 2 times, most recently from 1e973cd to 61a3ec0 Compare October 17, 2017 14:38
@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2017

Clean pick, merged upstream in 1.8. I'll leave the judgement about in or out of 3.7 to someone closer to the bug. @fabianofranz

/approve
/assign fabianofranz

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2017
@fabianofranz
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, fabianofranz, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install_update

1 similar comment
@juanvallejo
Copy link
Contributor Author

/test extended_conformance_install_update

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit fd08639 into openshift:master Oct 18, 2017
@juanvallejo juanvallejo deleted the jvallejo/bump-humanreadable-printer branch October 18, 2017 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants