Temporarily disable checking for multiple deployer pods until we have a fix for the controllers #16956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a fix for the controllers
openshift-ci-robot
added
the
size/XS
|
/lgtm |
openshift-merge-robot
added
the
approved
mfojtik
added
queue/blocks-others
queue/critical-fix
and removed
approved
openshift-merge-robot
added
the
approved
|
@smarterclayton queue unblocked, @tnozicka working on proper fix. |
|
/test cmd |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, tnozicka The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test extended_conformance_install_update |
|
Automatic merge from submit-queue. |
tnozicka
added a commit
to tnozicka/origin
that referenced
this pull request
Oct 24, 2017
tnozicka
added a commit
to tnozicka/origin
that referenced
this pull request
Oct 24, 2017
tnozicka
added a commit
to tnozicka/origin
that referenced
this pull request
Oct 26, 2017
tnozicka
added a commit
to tnozicka/origin
that referenced
this pull request
Oct 30, 2017
tnozicka
added a commit
to tnozicka/origin
that referenced
this pull request
Oct 30, 2017
tnozicka
added a commit
to tnozicka/origin
that referenced
this pull request
Nov 29, 2017
tnozicka
deleted the
disable-checking-deployer-invariant-until-we-have-a-fix
branch
openshift-merge-robot
added a commit
that referenced
this pull request
Nov 30, 2017
…e-to-cancellation Automatic merge from submit-queue (batch tested with PRs 17350, 16998). apps: extend extended tests to better check for deployer invariants and enable back the old check enabling back #16956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock the queue
related issue: #16870
cc: @mfojtik @smarterclayton