Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 45611: remove use of printf semantics for view-last-applied cmd #16983

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Oct 20, 2017

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1503601

Picks changes introduced in upstream PR kubernetes/kubernetes#45611 which removes printf() semantics from the output of apply view-last-applied. Using printf() was causing values with % to be interpreted as Go format code, which in turn adding unwanted statements such as (MISSING)! to the yaml / json output of the command.

cc @openshift/cli-review

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2017
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Oct 20, 2017
@deads2k
Copy link
Contributor

deads2k commented Oct 20, 2017

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, juanvallejo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2017
@juanvallejo
Copy link
Contributor Author

/test extended_conformance_gce

1 similar comment
@juanvallejo
Copy link
Contributor Author

/test extended_conformance_gce

@0xmichalis
Copy link
Contributor

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 21, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 3022908 into openshift:master Oct 21, 2017
@juanvallejo juanvallejo deleted the jvallejo/pick-upstream-pr-45611 branch October 23, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants