Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/bz1507664 suppress health checks #17155

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Bug/bz1507664 suppress health checks #17155

merged 2 commits into from
Nov 3, 2017

Commits on Nov 2, 2017

  1. Revert "Skip health checks when there is one server that backs the ro… 

    …ute"

This reverts commit 9835dca.
    @knobunc
    knobunc committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    e4ac5b0 View commit details
    Browse the repository at this point in the history

  2. Fix the "supress health checks when only one backing service" logic 

    Previously we had attempted to suppress the health checks, but it was looking at the endpoints of the service, not the servers that back the route. The problem is that if we just look at endpoints, then if a route has two backing services, each with one endpoint, we would incorrectly suppress the health checks.

This is the third attempt.  I had missed a case in the last one, so now the logic is moved to be computed and recorded by the router controller, but used in the template.

Fixes bug 1507664 (https://bugzilla.redhat.com/show_bug.cgi?id=1507664)
    @knobunc
    knobunc committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    8cb7b95 View commit details
    Browse the repository at this point in the history