-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add template.openshift.io/bindable annotation, default is true #17215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Nov 7, 2017
@openshift/api-review ptal |
/lgtm |
openshift-merge-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 7, 2017
bparees
added
kind/bug
Categorizes issue or PR as related to a bug.
and removed
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Nov 7, 2017
openshift-merge-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 7, 2017
jim-minter
force-pushed
the
issue16726
branch
from
November 7, 2017 14:29
f92192f
to
86e6419
Compare
openshift-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Nov 7, 2017
jim-minter
force-pushed
the
issue16726
branch
from
November 7, 2017 14:56
86e6419
to
92f42fa
Compare
/test cmd |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jim-minter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test unit |
Automatic merge from submit-queue. |
This was referenced Nov 7, 2017
This was referenced Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
Indicates that a PR is ready to be merged.
needs-api-review
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16726
will update quickstarts and pull them in after api review (and update docs).
@bparees @jorgemoralespou @spadgett