Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.7] UPSTREAM: 55631: Parse and return the last line in the log even if it is partial #17320

Closed
wants to merge 1 commit into from

Conversation

runcom
Copy link
Member

@runcom runcom commented Nov 15, 2017

Same as #17198 but for release-3.7.

@derekwaynecarr @mrunalp PTAL

Signed-off-by: Antonio Murdaca [email protected]

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Nov 15, 2017
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Nov 15, 2017

@Kargakis we should allow merge to 3.7 branches ;-)

@stevekuznetsov i think this will have to go via green button.

/test

@bparees
Copy link
Contributor

bparees commented Nov 15, 2017

/unassign

@stevekuznetsov
Copy link
Contributor

Branch weirdness will be fixed once we move away from mungegithub and to tide.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2017
@runcom
Copy link
Member Author

runcom commented Nov 15, 2017

/test crio

@derekwaynecarr derekwaynecarr removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2017
@derekwaynecarr
Copy link
Member

I want to hold on this until the upstream PR is actually merged.

@derekwaynecarr derekwaynecarr added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2017
@stevekuznetsov stevekuznetsov removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 15, 2017
@stevekuznetsov
Copy link
Contributor

Misunderstood comment from @mfojtik

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2017
@stevekuznetsov
Copy link
Contributor

/lgtm cancel
/approve cancel

@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2017
@runcom
Copy link
Member Author

runcom commented Nov 29, 2017

/test crio

1 similar comment
@runcom
Copy link
Member Author

runcom commented Nov 29, 2017

/test crio

@runcom
Copy link
Member Author

runcom commented Nov 29, 2017

@derekwaynecarr @stevekuznetsov we need this for 3.7 as well, could any of you merge this? (Upstream has merged)

@runcom
Copy link
Member Author

runcom commented Nov 29, 2017

just found out the repo to backport, closing.

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed vendor-update Touching vendor dir or related files labels Nov 30, 2017
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: runcom
We suggest the following additional approver: stevekuznetsov

Assign the PR to them by writing /assign @stevekuznetsov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added vendor-update Touching vendor dir or related files and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 30, 2017
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2017
@runcom
Copy link
Member Author

runcom commented Nov 30, 2017

As requested elsewhere by @smarterclayton - this is back porting #17198 to release-1.7

@openshift-ci-robot
Copy link

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end 618fa2f link /test end_to_end
ci/openshift-jenkins/extended_conformance_crio 618fa2f link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom
Copy link
Member Author

runcom commented Dec 1, 2017

Being back ported #17546

@runcom runcom closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants