-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase service catalog to v0.1.3 #17378
Conversation
/test service-catalog |
3 similar comments
/test service-catalog |
/test service-catalog |
/test service-catalog |
047e7fb
to
15421c1
Compare
/test service-catalog |
4 similar comments
/test service-catalog |
/test service-catalog |
/test service-catalog |
/test service-catalog |
/test extended_conformance_gce |
2 similar comments
/test extended_conformance_gce |
/test extended_conformance_gce |
@smarterclayton any chance you can approve this? |
/lgtm |
/approve cancel I'm going to wait until after 3.8 branch is cut for this to go in. |
killing jobs to free the queue. Will rekick |
/retest |
1 similar comment
/retest |
/retest |
…service-catalog/' changes from 3064247d05..d969acde90 d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583) 1bcd53b684 origin build: add origin tooling bb3e4a1 Chart changes for 0.1.3 (openshift#1573) 1d463c3 less etcd logs during integration test (openshift#1572) dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568) b636203 make binding poll function clone binding (openshift#1550) e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536) 4f47ce8 Embed etcd in the integration tests directly. (openshift#1570) d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519) 31ae521 Check if file permissions allow go install (openshift#1566) 52e64db Clear out plan ref when plan changed using k8s names (openshift#1553) 4b49594 Allow deprovision after change to non-existent plan (openshift#1557) c6e446e Consolidating logic for creating in-progress properties. (openshift#1511) fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544) b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538) c8d5610 update comments on NewStorage (openshift#1548) 35082df Update resources in walkthrough (openshift#1510) f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543) 02a5ff6 Add an additional plan to ups-broker (openshift#1537) 4309a0e add alpha asynchronous binding operation support (openshift#1512) 617c823 Grant controller abilit to update service/plan status (openshift#1532) 281ca9c Moving a duplicated block of code to an independent function. (openshift#1509) da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507) 48c522d Updating helm install documentation (openshift#1525) b89d59e Adding an independent test for originating_identity (openshift#1498) 6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497) 411831c Fixing missing pretty logging on controller_binding. (openshift#1520) REVERT: 3064247d05 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
15421c1
to
b0324ee
Compare
Going to label this to merge on green tests. |
/test extended_conformance_gce extended_conformance_install |
/approve |
/test extended_conformance_install |
1 similar comment
/test extended_conformance_install |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeeler, pmorie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test extended_conformance_install |
/test extended_conformance_install flake #17605 |
1 similar comment
/test extended_conformance_install flake #17605 |
Was told earlier today that a new AMI image could potentially solve the flake issue I'm seeing here, so here goes one more time. /test extended_conformance_install flake #17605 |
Saw some yum errors, trying again... |
/test extended_conformance_install |
1 similar comment
/test extended_conformance_install |
@jpeeler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Rebase service catalog to v0.1.3
This is a rebase to 0.1.3 plus a patch to make e2e test work. Mostly this rebase is to ensure that works correctly.