Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase service catalog to v0.1.3 #17378

Merged
merged 2 commits into from
Jan 4, 2018

Conversation

jpeeler
Copy link

@jpeeler jpeeler commented Nov 19, 2017

This is a rebase to 0.1.3 plus a patch to make e2e test work. Mostly this rebase is to ensure that works correctly.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 19, 2017
@openshift-merge-robot openshift-merge-robot added needs-api-review vendor-update Touching vendor dir or related files labels Nov 19, 2017
@jpeeler
Copy link
Author

jpeeler commented Nov 19, 2017

/test service-catalog

3 similar comments
@jpeeler
Copy link
Author

jpeeler commented Nov 20, 2017

/test service-catalog

@jpeeler
Copy link
Author

jpeeler commented Nov 20, 2017

/test service-catalog

@jpeeler
Copy link
Author

jpeeler commented Nov 20, 2017

/test service-catalog

@jpeeler
Copy link
Author

jpeeler commented Nov 20, 2017

/test service-catalog

4 similar comments
@jpeeler
Copy link
Author

jpeeler commented Nov 20, 2017

/test service-catalog

@jpeeler
Copy link
Author

jpeeler commented Nov 20, 2017

/test service-catalog

@jpeeler
Copy link
Author

jpeeler commented Nov 21, 2017

/test service-catalog

@jpeeler
Copy link
Author

jpeeler commented Nov 21, 2017

/test service-catalog

@jpeeler
Copy link
Author

jpeeler commented Nov 21, 2017

/test extended_conformance_gce

2 similar comments
@jpeeler
Copy link
Author

jpeeler commented Nov 21, 2017

/test extended_conformance_gce

@jpeeler
Copy link
Author

jpeeler commented Nov 21, 2017

/test extended_conformance_gce

@jpeeler jpeeler changed the title [DO NOT MERGE] Rebase to service catalog to v0.1.3 Rebase to service catalog to v0.1.3 Nov 22, 2017
@jpeeler jpeeler changed the title Rebase to service catalog to v0.1.3 Rebase service catalog to v0.1.3 Nov 22, 2017
@jpeeler
Copy link
Author

jpeeler commented Nov 22, 2017

@smarterclayton any chance you can approve this?

@pmorie
Copy link
Contributor

pmorie commented Nov 28, 2017

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2017
@pmorie
Copy link
Contributor

pmorie commented Nov 28, 2017

/approve cancel

I'm going to wait until after 3.8 branch is cut for this to go in.

@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2017
@deads2k
Copy link
Contributor

deads2k commented Nov 28, 2017

/approve cancel

I'm going to wait until after 3.8 branch is cut for this to go in.

killing jobs to free the queue. Will rekick

@jpeeler
Copy link
Author

jpeeler commented Dec 14, 2017

/retest

1 similar comment
@pmorie
Copy link
Contributor

pmorie commented Dec 15, 2017

/retest

@jpeeler
Copy link
Author

jpeeler commented Dec 15, 2017

/retest
last try for a while from me

Jeff Peeler added 2 commits December 15, 2017 11:34
…service-catalog/' changes from 3064247d05..d969acde90

d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
1bcd53b684 origin build: add origin tooling
bb3e4a1 Chart changes for 0.1.3 (openshift#1573)
1d463c3 less etcd logs during integration test (openshift#1572)
dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568)
b636203 make binding poll function clone binding (openshift#1550)
e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536)
4f47ce8 Embed etcd in the integration tests directly. (openshift#1570)
d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519)
31ae521 Check if file permissions allow go install (openshift#1566)
52e64db Clear out plan ref when plan changed using k8s names (openshift#1553)
4b49594 Allow deprovision after change to non-existent plan (openshift#1557)
c6e446e Consolidating logic for creating in-progress properties. (openshift#1511)
fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544)
b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538)
c8d5610 update comments on NewStorage (openshift#1548)
35082df Update resources in walkthrough (openshift#1510)
f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543)
02a5ff6 Add an additional plan to ups-broker (openshift#1537)
4309a0e add alpha asynchronous binding operation support (openshift#1512)
617c823 Grant controller abilit to update service/plan status (openshift#1532)
281ca9c Moving a duplicated block of code to an independent function. (openshift#1509)
da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507)
48c522d Updating helm install documentation (openshift#1525)
b89d59e Adding an independent test for originating_identity (openshift#1498)
6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497)
411831c Fixing missing pretty logging on controller_binding. (openshift#1520)
REVERT: 3064247d05 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2017
@stevekuznetsov
Copy link
Contributor

Going to label this to merge on green tests.

@jpeeler
Copy link
Author

jpeeler commented Dec 15, 2017

/test extended_conformance_gce extended_conformance_install

@pmorie
Copy link
Contributor

pmorie commented Dec 15, 2017

/approve

@jpeeler
Copy link
Author

jpeeler commented Dec 15, 2017

/test extended_conformance_install

1 similar comment
@jpeeler
Copy link
Author

jpeeler commented Dec 16, 2017

/test extended_conformance_install

@pmorie
Copy link
Contributor

pmorie commented Dec 18, 2017

/retest

1 similar comment
@jpeeler
Copy link
Author

jpeeler commented Jan 3, 2018

/retest

@pmorie
Copy link
Contributor

pmorie commented Jan 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpeeler, pmorie

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jpeeler
Copy link
Author

jpeeler commented Jan 3, 2018

/test extended_conformance_install

@jpeeler
Copy link
Author

jpeeler commented Jan 3, 2018

/test extended_conformance_install flake #17605

1 similar comment
@pmorie
Copy link
Contributor

pmorie commented Jan 3, 2018

/test extended_conformance_install flake #17605

@jpeeler
Copy link
Author

jpeeler commented Jan 3, 2018

Was told earlier today that a new AMI image could potentially solve the flake issue I'm seeing here, so here goes one more time.

/test extended_conformance_install flake #17605

@jpeeler
Copy link
Author

jpeeler commented Jan 3, 2018

Saw some yum errors, trying again...
/test extended_conformance_install

@pmorie
Copy link
Contributor

pmorie commented Jan 4, 2018

/test extended_conformance_install

1 similar comment
@pmorie
Copy link
Contributor

pmorie commented Jan 4, 2018

/test extended_conformance_install

@openshift-ci-robot
Copy link

@jpeeler: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update 15421c1 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_install b0324ee link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor

Merging after a conversation with @jpeeler and @pmorie

@stevekuznetsov stevekuznetsov merged commit 188906e into openshift:master Jan 4, 2018
jpeeler pushed a commit to jpeeler/aos-cd-jobs that referenced this pull request Jan 4, 2018
mjudeikis pushed a commit to mjudeikis/origin that referenced this pull request Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review retest-not-required size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants