Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dockerregistry Dockerfile and build #17388

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Remove dockerregistry Dockerfile and build #17388

merged 1 commit into from
Nov 21, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Nov 20, 2017

The docker registry is built by the make images step of the image-registry repo, remove it from being rebuilt as part of the origin build.

e2e should (should) pick up the already built image because it gets cross-tagged.

When we branch 3.8, we'll need to ensure the 3.8 branch of the image registry is tested with with 3.8 branch of origin

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2017
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Nov 20, 2017

/assign @mfojtik @stevekuznetsov

@liggitt
Copy link
Contributor Author

liggitt commented Nov 20, 2017

/test extended_builds
/test extended_image_ecosystem

@stevekuznetsov
Copy link
Contributor

Investigating e2e job

@liggitt
Copy link
Contributor Author

liggitt commented Nov 20, 2017

it's not clear what image cluster up was trying to pull for the registry

@stevekuznetsov
Copy link
Contributor

We were trying to pull the right one:

[INFO] Using images:							openshift/origin-${component}:b5b4d46

We just aren't building it in that job. Will fix

@stevekuznetsov
Copy link
Contributor

/test end-to-end

@liggitt
Copy link
Contributor Author

liggitt commented Nov 20, 2017

/test end_to_end

@liggitt
Copy link
Contributor Author

liggitt commented Nov 20, 2017

/test extended_builds
/test extended_image_ecosystem

@liggitt
Copy link
Contributor Author

liggitt commented Nov 20, 2017

/test extended_clusterup

@liggitt
Copy link
Contributor Author

liggitt commented Nov 20, 2017

/test extended_image_registry

@soltysh soltysh mentioned this pull request Nov 20, 2017
19 tasks
@liggitt
Copy link
Contributor Author

liggitt commented Nov 21, 2017

/test extended_clusterup

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Nov 21, 2017

/test extended_clusterup

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 3067e36 into openshift:master Nov 21, 2017
@openshift-ci-robot
Copy link

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update b5b4d46 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_clusterup b5b4d46 link /test extended_clusterup
ci/openshift-jenkins/extended_conformance_gce b5b4d46 link /test extended_conformance_gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt liggitt deleted the dockerregistry branch November 22, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants