-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dockerregistry Dockerfile and build #17388
Remove dockerregistry Dockerfile and build #17388
Conversation
/assign @mfojtik @stevekuznetsov |
/test extended_builds |
Investigating e2e job |
it's not clear what image |
We were trying to pull the right one:
We just aren't building it in that job. Will fix |
/test end-to-end |
/test end_to_end |
/test extended_builds |
/test extended_clusterup |
/test extended_image_registry |
/test extended_clusterup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test extended_clusterup |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
@liggitt: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The docker registry is built by the
make images
step of the image-registry repo, remove it from being rebuilt as part of the origin build.e2e should (should) pick up the already built image because it gets cross-tagged.
When we branch 3.8, we'll need to ensure the 3.8 branch of the image registry is tested with with 3.8 branch of origin