Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove openshift cli and friends #17396

Merged
merged 3 commits into from
Nov 22, 2017
Merged

remove openshift cli and friends #17396

merged 3 commits into from
Nov 22, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Nov 20, 2017

removes

  1. openshift cli
  2. openshift admin
  3. osc
  4. oadm
  5. osadm

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2017
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 20, 2017
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2017
soltysh
soltysh approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 21, 2017
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Nov 21, 2017

/retest

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2017
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2017
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2017
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Nov 21, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_update d6b88e2 link /test extended_conformance_install_update
ci/openshift-jenkins/extended_conformance_gce d6b88e2 link /test extended_conformance_gce
ci/openshift-jenkins/end_to_end d6b88e2 link /test end_to_end

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 17396, 17415).

@openshift-merge-robot openshift-merge-robot merged commit 63979f9 into openshift:master Nov 22, 2017
@sdodson
Copy link
Member

sdodson commented Dec 7, 2017

@deads2k which package provides the client binaries now?

@wanghaoran1988
Copy link
Member

@deads2k @mfojtik @soltysh Why we remove oadm command? as currently a lot tools that use the oadm, not only the automation framework qe used, but also the installer, and I think a lot customer also are using this.

@sdodson
Copy link
Member

sdodson commented Dec 8, 2017

The installer was fixed yesterday FWIW.

@vikram-redhat
Copy link

@sdodson - is this for 3.9 or future? This will have a major impact on the docs.

FYI: @adellape @aheslin

@wanghaoran1988
Copy link
Member

@vikram-redhat This already happening in the 3.8

@miminar miminar mentioned this pull request Dec 14, 2017
Merged
@deads2k deads2k deleted the bin-07-remove-cli branch January 24, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@deads2k @openshift-merge-robot @openshift-ci-robot @sdodson @wanghaoran1988 @vikram-redhat @soltysh @liggitt