Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - Make deployer controller to respect 3 laws of controllers #17499

Closed
wants to merge 1 commit into from
Closed

[WIP] - Make deployer controller to respect 3 laws of controllers #17499

wants to merge 1 commit into from

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Nov 28, 2017 •
edited
Loading

We could potentially delete wrong deployer pods if the same DC is deleted and recreated.

/cc @mfojtik

(needs tests)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tnozicka
We suggest the following additional approver: kargakis

Assign the PR to them by writing /assign @kargakis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2017
@0xmichalis 0xmichalis removed their assignment Nov 28, 2017
@openshift-ci-robot
Copy link

@tnozicka: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 2fe596f link /test cmd
ci/openshift-jenkins/integration 2fe596f link /test integration
ci/openshift-jenkins/end_to_end 2fe596f link /test end_to_end
ci/openshift-jenkins/unit 2fe596f link /test unit
ci/openshift-jenkins/extended_conformance_gce 2fe596f link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install 2fe596f link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mfojtik
mfojtik reviewed Nov 29, 2017
View reviewed changes
pkg/apps/controller/deployer/deployer_controller.go
return err
}

{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to scope variables and not to leak names since this is to be removed after the interim

mfojtik
mfojtik reviewed Nov 29, 2017
View reviewed changes
pkg/apps/controller/deployer/deployer_controller.go
@@ -375,6 +389,7 @@ func (c *DeploymentController) makeDeployerPod(deployment *v1.ReplicationControl

gracePeriod := int64(10)

t := true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there is BoolPtr() helper ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create one and don't use t as a variable name, it's hard to follow what's it's about.

soltysh
soltysh reviewed Nov 29, 2017
View reviewed changes
pkg/apps/strategy/support/lifecycle.go
@@ -384,6 +384,7 @@ func makeHookPod(hook *deployapi.LifecycleHook, rc *kapi.ReplicationController,
podSecurityContextCopy := rc.Spec.Template.Spec.SecurityContext.DeepCopy()
securityContextCopy := baseContainer.SecurityContext.DeepCopy()

t := true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@openshift-merge-robot
Copy link
Contributor

@tnozicka PR needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2017
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2018
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 13, 2018
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik mfojtik left review comments

@soltysh soltysh soltysh left review comments

Assignees

@soltysh soltysh

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tnozicka @openshift-merge-robot @openshift-ci-robot @openshift-bot @mfojtik @soltysh @0xmichalis