UPSTREAM: 54597: kubelet: check for illegal container state transition

[tnozicka]

/cc @sjenning @smarterclayton @mfojtik

Fixes: #17487

[sjenning]

/lgtm

[tnozicka]

submit queue stuck...
/test all

[mfojtik]

/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sjenning, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• vendor/k8s.io/kubernetes/pkg/kubelet/OWNERS [mfojtik]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[tnozicka]

/retest

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17486, 17514).

[openshift-ci-robot]

@tnozicka: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_update	21271eb	link	/test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sjenning]

I see this change twice in the log for release-3.8 and master now

$ git log --oneline origin/master | grep "check for illegal container"
21271eb483 UPSTREAM: 54597: kubelet: check for illegal container state transition
912426b0f5 UPSTREAM: 54597: kubelet: check for illegal container state transition
$ git log --oneline origin/release-3.8 | grep "check for illegal container"
21271eb483 UPSTREAM: 54597: kubelet: check for illegal container state transition
912426b0f5 UPSTREAM: 54597: kubelet: check for illegal container state transition
$ git log --oneline origin/release-3.7 | grep "check for illegal container"
912426b0f5 UPSTREAM: 54597: kubelet: check for illegal container state transition

Is it reverted somewhere in 3.8/master then reapplied by this PR? fyi @frobware

[sjenning]

$ git log --oneline origin/release-3.8 -- vendor/k8s.io/kubernetes/pkg/kubelet/status/status_manager.go
21271eb483 UPSTREAM: 54597: kubelet: check for illegal container state transition
c4b40b3f40 bump(k8s.io/kubernetes): 0d5291cc63b7b3655b11bc15e8afb9a078049d09 - v1.8.1
912426b0f5 UPSTREAM: 54597: kubelet: check for illegal container state transition

Seems the bump to 1.8.1 reverted it. I guess nothing to see here. Weird workflow though.