Poll for server start using impersonation #17613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we poll for server start on `/healthz` and/or `/healthz/ready` with the administrative `$KUBECONFIG` we do so as part of the `system:masters` group and therefore the response fromt these endpoints will succeed before the RBAC system is initialized as we bypass it. Using impersonation here allows the poll on these endpoints to not only wait for the server to start but also to wait for the RBAC initialization. Signed-off-by: Steve Kuznetsov <[email protected]>
openshift-ci-robot
requested review from
deads2k,
enj,
liggitt,
knobunc and
soltysh
openshift-ci-robot
added
approved
stevekuznetsov
added
area/tests
kind/bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, stevekuznetsov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
enj
approved these changes
Dec 5, 2017
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/cherrypick release-3.8 |
|
@liggitt: new pull request created: #17975 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
added a commit
that referenced
this pull request
Jan 5, 2018
…-17613-to-release-3.8 Automatic merge from submit-queue. [release-3.8] Poll for server start using impersonation This is an automated cherry-pick of #17613 /assign liggitt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we poll for server start on
/healthzand/or/healthz/readywiththe administrative
$KUBECONFIGwe do so as part of thesystem:mastersgroup and therefore the response fromt these endpointswill succeed before the RBAC system is initialized as we bypass it.
Using impersonation here allows the poll on these endpoints to not only
wait for the server to start but also to wait for the RBAC
initialization.
Signed-off-by: Steve Kuznetsov [email protected]
/cc @liggitt @deads2k @enj
Fixes #17574