tweak failing-dc e2e test with sleep so docker have time to get the hook container logs #17746
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
mfojtik
force-pushed
the
tweak-dc-e2e-test
branch
from
5e9ba88
to
2bb8f26
Compare
|
the logs issue is tracked in #17747 |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
test/end-to-end/core.sh
Outdated
| @@ -405,7 +405,10 @@ os::cmd::try_until_text 'oc get pods -l openshift.io/deployer-pod.type=hook-post | |||
| os::cmd::expect_success 'oc create -f test/testdata/failing-dc.yaml' | |||
| os::cmd::try_until_success 'oc get rc/failing-dc-1' | |||
| os::cmd::expect_failure 'oc rollout status dc/failing-dc' | |||
| os::cmd::expect_success_and_text 'oc logs dc/failing-dc' 'test pre hook executed' | |||
| # FIXME: getting the hook logs seems to be flaking, re-enable when we find the | |||
There was a problem hiding this comment.
Please don't do it like this :( we need the test, we just need to slightly modify it so that docker has a chance to get that last line. Add sleep 1 like here in test/testdata/failing-dc.yamlrather than disabling this test.
/hold
There was a problem hiding this comment.
please don't do sleep 1 that just makes the flake less common, not fixed.
There was a problem hiding this comment.
agree with @tnozicka adding sleep 1 will just hide this problem and we will never get to fixing it.
There was a problem hiding this comment.
We (openshift team) don't own docker and we won't fix it, we can't block our team just to know about this bug. There should be an open issue to remove those sleeps but for now we need to limit the # of flakes.
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
mfojtik
force-pushed
the
tweak-dc-e2e-test
branch
from
2bb8f26
to
b2ebb72
Compare
openshift-ci-robot
added
size/S
openshift-merge-robot
removed
the
lgtm
…om hook container
mfojtik
force-pushed
the
tweak-dc-e2e-test
branch
from
b2ebb72
to
6ace95d
Compare
mfojtik
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, soltysh, tnozicka The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@runcom I wonder if something similar like this is happening also with CRI-O |
|
flake: #13068 (and others..) /retest |
|
We haven't seen failures on the cri-o side actually :) |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@mfojtik: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 17572, 17746). |
This tweaks the fixture for e2e test where the hook pod is executing really fast and Docker daemon seems to not have enough time to gather the container logs. This is NOT fixing the issue with Docker, but unblocking the queue as this is flaking hard... We should still continue to investigate the issue in Docker.
@tnozicka @deads2k