Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prometheus readme: bld phase/reason conversion to all lower case … #17809

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

gabemontero
Copy link
Contributor

…was reverted

@openshift/sig-developer-experience

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 14, 2017
@bparees
Copy link
Contributor

bparees commented Dec 14, 2017

I don't remember the history on this. How did we end up with CamelCase for metric names and is that what everyone will use?

@gabemontero
Copy link
Contributor Author

Its the value of the metric labels ....we have "phase" and "reason" labels ....originally we were converting values of the build phase and reason fields from the build object (which are camel case) to all lower case, and then in one of PRs that followed the initial delivery of build metrics, during one of the reviews @smarterclayton said to no longer do that conversion.

@bparees
Copy link
Contributor

bparees commented Dec 14, 2017

thanks
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2017
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2017
@openshift-ci-robot
Copy link

@gabemontero: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_image_ecosystem f1194fd link /test extended_image_ecosystem

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 2b1b989 into openshift:master Dec 14, 2017
@gabemontero gabemontero deleted the fix-prom-readme branch December 14, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants