SCC admission plugin: extract name to a constant

[php-coder]

I hope that it won't create unnecessary package coupling.

PTAL @pweil- @liggitt
CC @simo5

[php-coder]

Test flake #17873
/test extended_conformance_gce

[php-coder]

@pweil- @enj PTAL

[enj]

/approve

@deads2k please LGTM if you are happy with the change to the dependency graph.

[deads2k]

/approve

@deads2k please LGTM if you are happy with the change to the dependency graph.

We may end up taking this in the other direction (dependency-wise), but I'm ok with it for now since we already depend in that direction.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj, php-coder

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cmd/OWNERS [deads2k,enj]
• pkg/security/OWNERS [deads2k,enj]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[php-coder]

Test flake #17969
/test extended_conformance_gce

[php-coder]

Test flake #17605
/test extended_conformance_install

[php-coder]

Tests failed because of #17985
I'll re-run them later when it will be fixed.

[php-coder]

/retest

[php-coder]

e2e test failed because of #18000
/test end_to_end

[php-coder]

Test flake #16994
/test extended_conformance_install

[php-coder]

The following 3 tests failed:

• [Feature:Builds][Conformance] build without output image building from templates should create an image from a S2i template without an output image reference defined [Suite:openshift/conformance/parallel]
• [sig-api-machinery] Downward API should provide host IP as an env var [Conformance] [Suite:openshift/conformance/parallel] [Suite:k8s]
• [sig-storage] Projected should be able to mount in a volume regardless of a different secret existing with same name in different namespace [Suite:openshift/conformance/parallel] [Suite:k8s]

Most likely all they were killed by timeout:

[INFO] test/extended/conformance.sh exited with code 0 after 01h 38m 58s
make: *** [test-extended] Terminated

	 -------------------------------------------------------------------
	|                                                                   |
	|  Ginkgo timed out waiting for all parallel nodes to report back!  |
	|                                                                   |
	 -------------------------------------------------------------------

/test extended_conformance_gce

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17856, 16934, 17979, 17993, 18001).