Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run openshift and kube controllers on different leases #17861

Merged
merged 2 commits into from
Dec 22, 2017
Merged

run openshift and kube controllers on different leases #17861

merged 2 commits into from
Dec 22, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Dec 18, 2017

In 3.7, we started using secondary leases for the scheduler and the kube controllers. In the 3.9 rebase, we separate informers. This pull completes the leasing and running separation.

@smarterclayton @soltysh
/assign @soltysh

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 18, 2017
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 18, 2017

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2017
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2017
soltysh
soltysh approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 21, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Dec 21, 2017

#17605

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Dec 22, 2017

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Dec 22, 2017

/retest

@soltysh
Copy link
Contributor

soltysh commented Dec 22, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit d017a2b into openshift:master Dec 22, 2017
@deads2k deads2k deleted the controller-16-wait-3.9 branch January 24, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@enj enj Awaiting requested review from enj

@humblec humblec Awaiting requested review from humblec

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @openshift-ci-robot @soltysh @openshift-merge-robot