Remove numerous "Provided subnet doesn't belong to network" when configured with multiple subnets #17973
Conversation
If there are multiple clusterNetworkCIDR values on startup when generating the SubnetAllocators for each range "Provided subnet doesn't belong to network" gets printed after each subnet that belongs to a different range. I sorted the list of subnets so that each call to NewSubnetAllocator has the list of subnets that are within the clusterNetworkCIDR's range
openshift-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JacobTanenbaum, rajatchopra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Please set a better title for the PR so it's recognizable in search results, etc Also, if you say: Fixes #17475 in the initial comment, then github will automatically close that issue when this PR is merged. (I think it only works if that's in the initial comment though, so my saying it here won't work. But you can edit the initial comment to fix it.) |
| subrange[cn] = append(subrange[cn], sub.Subnet) | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
Hm... this would end up skipping the subnet if it doesn't match any ClusterNetwork, but we already sanity-checked the HostSubnets before this anyway so I guess that's ok.
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
JacobTanenbaum
changed the title
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Automatic merge from submit-queue. |
If there are multiple clusterNetworkCIDR values on startup when generating the SubnetAllocators for each range
"Provided subnet doesn't belong to network"gets printed after each subnet that belongs to a different range.I sorted the list of subnets so that each call to NewSubnetAllocator has the list of subnets that are within the clusterNetworkCIDR's range
Fixes #17475