Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cluster up for console config API changes #18114

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Update cluster up for console config API changes #18114

merged 1 commit into from
Jan 19, 2018

Conversation

spadgett
Copy link
Member

Adopt API changes from openshift/api#31

For now, both the new and old config need to be written to avoid breaking cluster up until origin-web-console-server is updated.

/assign @deads2k
@jwforres FYI

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2018
@spadgett spadgett mentioned this pull request Jan 15, 2018
Merged
@deads2k
Copy link
Contributor

deads2k commented Jan 15, 2018

@spadgett let me know when it is ready for review.

@spadgett spadgett mentioned this pull request Jan 15, 2018
Merged
@spadgett spadgett changed the title [WIP] Update cluster up for console config API changes Update cluster up for console config API changes Jan 15, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2018
@spadgett
Copy link
Member Author

/retest

I've tested also with a web console image built from openshift/origin-web-console-server#20

@deads2k PTAL

@deads2k
Copy link
Contributor

deads2k commented Jan 15, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, spadgett

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2018
@spadgett
Copy link
Member Author

spadgett commented Jan 15, 2018 •
edited
Loading

/test extended_conformance_gce

@spadgett
Copy link
Member Author

/retest

2 similar comments
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

Opened flake #18122

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

/retest

2 similar comments
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

spadgett commented Jan 17, 2018 •
edited
Loading

This blocks several follow on PRs across several repositories

@spadgett
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2018
@openshift-merge-robot openshift-merge-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2018
@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2018
@spadgett
Copy link
Member Author

/retest

3 similar comments
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

flake #16832

@spadgett spadgett mentioned this pull request Jan 18, 2018
Merged
@spadgett
Copy link
Member Author 

[openshift/origin-pod] Cannot find a valid baseurl for repo: base/7/x86_64
[openshift/origin-pod] Could not retrieve mirrorlist http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=container error was
[openshift/origin-pod] 12: Timeout on http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=container: (28, 'Operation too slow. Less than 1000 bytes/sec transferred the last 30 seconds')

/retest

@spadgett
Copy link
Member Author

flake #17556

/retest

@spadgett
Copy link
Member Author

spadgett commented Jan 18, 2018 •
edited
Loading

/test extended_conformance_install

@spadgett
Copy link
Member Author

flake #18136

/test extended_conformance_install

@spadgett
Copy link
Member Author

flake #17556

/test extended_conformance_install

@spadgett
Copy link
Member Author

Opened flake #18188

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 0f43934 into openshift:master Jan 19, 2018
@spadgett spadgett deleted the console-config-api-changes branch January 19, 2018 16:19
@spadgett spadgett mentioned this pull request Jan 19, 2018
Merged
openshift-merge-robot added a commit that referenced this pull request Jan 25, 2018
@openshift-merge-robot
Merge pull request #18191 from spadgett/cluster-up-remove-old-asset-c…
d5f454d 
…onfig

Automatic merge from submit-queue (batch tested with PRs 18191, 18264, 18235, 18251, 18271).

cluster up: remove obsolete asset config properties

Follow on to #18114 
Requires openshift/origin-web-console-server#20

/assign @deads2k 
@jwforres @sdodson FYI
/hold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@deads2k deads2k Awaiting requested review from deads2k

@jim-minter jim-minter Awaiting requested review from jim-minter

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/blocks-others size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spadgett @deads2k @openshift-ci-robot @openshift-bot @openshift-merge-robot