UPSTREAM: 52324: Fix bug on kubelet failure to umount mount points. #18225
Conversation
openshift-merge-robot
added
the
vendor-update
openshift-ci-robot
added
the
size/L
|
/assign @jsafrane |
|
/retest |
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
I havent updated the bazel inside the vendor directory, not sure is that causing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
| // util.go uses api.Codecs.LegacyCodec so import this package to do some | ||
| // resource initialization. | ||
| _ "k8s.io/kubernetes/pkg/apis/core/install" | ||
| "k8s.io/kubernetes/pkg/apis/core/v1/helper" | ||
| "k8s.io/kubernetes/vendor/k8s.io/kubernetes/pkg/util/mount" |
There was a problem hiding this comment.
you should not import vendor packages.
can't load package: package k8s.io/kubernetes/vendor/k8s.io/kubernetes/pkg/util/mount: cannot find package "k8s.io/kubernetes/vendor/k8s.io/kubernetes/pkg/util/mount" in any of:
/usr/local/go/src/k8s.io/kubernetes/vendor/k8s.io/kubernetes/pkg/util/mount (from $GOROOT)
/go/src/github.com/openshift/origin/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/kubernetes/pkg/util/mount (from $GOPATH)
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: Humble Chirammal <[email protected]>
humblec
force-pushed
the
kubelet-mount-fix
branch
from
f5a2f3f
to
0727d1d
Compare
openshift-merge-robot
removed
the
lgtm
|
Thanks @jsafrane . All tests are green now :). |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@humblec: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 18225, 18351, 18331, 18340, 18326). |
|
@humblec any chance this can be merged in 3.7 origin too ? otherwise everyone using Origin 3.7 is ... stuck @jarrpa fyi which came as result of https://bugzilla.redhat.com/show_bug.cgi?id=1489082 We on 3.7 origin hitting it everytime now and honestly is a NO-GO for prod |
|
@DanyC97 this is fixed in OCP 3.7 some time back, so if you are running latest OCP 3.7 version you should not hit this issue. |
Signed-off-by: Humble Chirammal [email protected]