UPSTREAM: 58547: Send correct resource version for delete events from watch cache

[tnozicka]

Backport of kubernetes/kubernetes#58547

Watch cache was returning incorrect (old) ResourceVersion on "deleted" events breaking informers that were going back in time. This fixes it.

/assign @liggitt
/cc @mfojtik

Fixes #17581 #16003 and likely others

[tnozicka]

/test cmd

[liggitt]

can you also pick to 3.8 and 3.7 (origin and ose)? picking from the cherry-pick PRs upstream should avoid conflicts

[tnozicka]

@liggitt I was about to ask you from which version we enabled the cache; now I know :)

[tnozicka]

/cherrypick release-3.8
(let's see if it works first)

[openshift-cherrypick-robot]

@tnozicka: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tnozicka]

/test cmd

[tnozicka]

/cherrypick release-3.7
(let's see if it works first)

[openshift-cherrypick-robot]

@tnozicka: once the present PR merges, I will cherry-pick it on top of release-3.7
in a new PR and assign it to you.

In response to this:

/cherrypick release-3.7
(let's see if it works first)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tnozicka]

/test extended_conformance_install

[liggitt]

(let's see if it works first)

it won't... there were conflicts. pick the upstream cherry picks

[liggitt]

@liggitt I was about to ask you from which version we enabled the cache; now I know :)

we enabled it before that, but that's as far back as I'd pick this for now

[liggitt]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• vendor/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/storage/OWNERS [liggitt]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[tnozicka]

/test integration

[tnozicka]

/test extended_conformance_install

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 18233, 18068, 18228, 18227).

[openshift-cherrypick-robot]

@tnozicka: cannot checkout release-3.8
: error checking out release-3.8
: exit status 1. output: error: pathspec 'release-3.8?' did not match any file(s) known to git.

In response to this:

/cherrypick release-3.8
(let's see if it works first)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@tnozicka: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install	6f1df56	link	/test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.