Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 58617: Make ExpandVolumeDevice() idempotent if existing volume capacity meets the requested size #18432

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Feb 5, 2018

Signed-off-by: Humble Chirammal [email protected]

…ume capacity meets the requested size

Signed-off-by: Humble Chirammal <[email protected]>
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 5, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2018
@humblec
Copy link
Contributor Author

humblec commented Feb 5, 2018

/assign @gnufied

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2018
@humblec
Copy link
Contributor Author

humblec commented Feb 5, 2018

/test gcp

@jsafrane
Copy link
Contributor

jsafrane commented Feb 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, jsafrane

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor

jsafrane commented Feb 5, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@gnufied
Copy link
Member

gnufied commented Feb 5, 2018

@humblec did we backport the PR that fixes logic of fetching existing volume from heketi? I think - this PR will not work properly without that other PR right?

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 8e8b874 into openshift:master Feb 5, 2018
@humblec
Copy link
Contributor Author

humblec commented Feb 5, 2018

@gnufied u mean the annotation PR which correctly fetch the volid ? if yes, I have already backported it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants