Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found #18475

Merged
merged 1 commit into from
Feb 26, 2018
Merged

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found #18475

merged 1 commit into from
Feb 26, 2018

Conversation

ravisantoshgudimetla
Copy link
Contributor

Scheduler is not able to read from config file if configmap is not found.

Upstream PR: kubernetes/kubernetes#59386

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785

/cc @aveshagarwal @sjenning

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 6, 2018
@aveshagarwal
Copy link
Contributor

@ravisantoshgudimetla thanks.

@aveshagarwal
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2018
@aveshagarwal
Copy link
Contributor

flake: #18486

@aveshagarwal
Copy link
Contributor

/test gcp
/test extended_conformance_install
/test extended_networking_minimal

@aveshagarwal
Copy link
Contributor

@derekwaynecarr or @smarterclayton could you please approve?

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@sjenning
Copy link
Contributor

sjenning commented Feb 7, 2018

CI provisioning failure
/retest

@aveshagarwal
Copy link
Contributor

/retest

@aveshagarwal
Copy link
Contributor

@smarterclayton could you approve?

@aveshagarwal
Copy link
Contributor

/retest

@sjenning
Copy link
Contributor

sjenning commented Feb 9, 2018

still failing to provision
/retest

@aveshagarwal aveshagarwal mentioned this pull request Feb 9, 2018
Closed
@aveshagarwal
Copy link
Contributor

aveshagarwal commented Feb 9, 2018 •
edited
Loading

flake: #18527

@aveshagarwal
Copy link
Contributor

/retest

@aveshagarwal
Copy link
Contributor

openshift/openshift-ansible#7089 fixes NoVolumeNodeConflict predicate issue.

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, derekwaynecarr, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2018
@sjenning
Copy link
Contributor

/retest

@ravisantoshgudimetla
Copy link
Contributor Author

/test gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sjenning
Copy link
Contributor

i think you might need to rebase this to pick up some fix

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@0xmichalis
Copy link
Contributor

/test gcp

2 similar comments
@0xmichalis
Copy link
Contributor

/test gcp

@0xmichalis
Copy link
Contributor

/test gcp

@0xmichalis
Copy link
Contributor

/test extended_conformance_install

1 similar comment
@0xmichalis
Copy link
Contributor

/test extended_conformance_install

@ravisantoshgudimetla
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@ravisantoshgudimetla
Copy link
Contributor Author

/test unit

@ravisantoshgudimetla
Copy link
Contributor Author

/test extended_networking_minimal

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit a1c2561 into openshift:master Feb 26, 2018
@ravisantoshgudimetla ravisantoshgudimetla deleted the fix-scheduler-config-flag branch March 4, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@smarterclayton smarterclayton

@aveshagarwal aveshagarwal

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ravisantoshgudimetla @aveshagarwal @sjenning @derekwaynecarr @openshift-ci-robot @openshift-bot @0xmichalis @openshift-merge-robot @smarterclayton