Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the upstream SA token controller #18508

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 7, 2018

This patches in our service serving cert CA initialization in the upstream SA token controller when requested. This makes it easier to run the upstream controllers in 3.10 and doing it in 3.9 makes for a smooth transition on the leases.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 7, 2018
@simo5
Copy link
Contributor

simo5 commented Feb 7, 2018

/unassign

@deads2k deads2k force-pushed the controller-04-satoken branch 2 times, most recently from bb1d044 to 30b12a7 Compare February 9, 2018 18:16
@deads2k
Copy link
Contributor Author

deads2k commented Feb 9, 2018

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Feb 12, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 12, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 12, 2018

/assign @mfojtik

prereq for cluster up

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18591, 18508).

@openshift-merge-robot openshift-merge-robot merged commit da1711d into openshift:master Feb 13, 2018
@openshift-ci-robot
Copy link

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install cedcafd link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Contributor

This probably introduced a flake. Please fix (1/5-1/6 runs)

[sig-network] Networking Granular Checks: Pods should function for intra-pod communication: http [Conformance] [Suite:openshift/conformance/parallel] [Suite:k8s] 26s

/tmp/openshift/build-rpms/rpm/BUILD/origin-3.9.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:648
Error creating Pod
Expected error:
    <*errors.StatusError | 0xc420274ea0>: {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {SelfLink: "", ResourceVersion: "", Continue: ""},
            Status: "Failure",
            Message: "No API token found for service account \"default\", retry after the token is automatically created and added to the service account",
            Reason: "ServerTimeout",
            Details: {
                Name: "create pod",
                Group: "",
                Kind: "serviceaccounts",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 1,
            },
            Code: 500,
        },
    }
    No API token found for service account "default", retry after the token is automatically created and added to the service account
not to have occurred
/tmp/openshift/build-rpms/rpm/BUILD/origin-3.9.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/pods.go:76

https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_extended_conformance_gce/2510/

and

[sig-storage] Projected should be consumable from pods in volume [Conformance] [Suite:openshift/conformance/parallel] [Suite:k8s] 25s

/tmp/openshift/build-rpms/rpm/BUILD/origin-3.9.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:648
Error creating Pod
Expected error:
    <*errors.StatusError | 0xc420d42ab0>: {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {SelfLink: "", ResourceVersion: "", Continue: ""},
            Status: "Failure",
            Message: "No API token found for service account \"default\", retry after the token is automatically created and added to the service account",
            Reason: "ServerTimeout",
            Details: {
                Name: "create pod",
                Group: "",
                Kind: "serviceaccounts",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 1,
            },
            Code: 500,
        },
    }
    No API token found for service account "default", retry after the token is automatically created and added to the service account
not to have occurred
/tmp/openshift/build-rpms/rpm/BUILD/origin-3.9.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/pods.go:76

https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_extended_conformance_gce/2511/

and https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_extended_conformance_gce/2501/

and https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_extended_conformance_gce/2500/

and https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_extended_conformance_gce/2494/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants