Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] Backport dc trigger reconciliation on image change release #18524

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Feb 8, 2018

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 8, 2018
@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 8, 2018

/test end_to_end

@tnozicka tnozicka force-pushed the backport-dc-trigger-reconciliation-on-image-change-release-3.7 branch from ba4e314 to 052e116 Compare February 8, 2018 13:34
@tnozicka tnozicka force-pushed the backport-dc-trigger-reconciliation-on-image-change-release-3.7 branch from 052e116 to 030fac4 Compare February 8, 2018 14:15
@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 8, 2018

/test cmd

@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 8, 2018

/test extended_image_registry

@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 8, 2018

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 9, 2018

/test gcp

@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 9, 2018

@mfojtik tests are green ;)

@mfojtik
Copy link
Contributor

mfojtik commented Feb 9, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Feb 9, 2018

/retest

2 similar comments
@mfojtik
Copy link
Contributor

mfojtik commented Feb 9, 2018

/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 9, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@LarsMilland
Copy link

@tnozicka it appears to be very difficult to get a clean run of all the required tests in order to complete the pull request and merge the code base. Looking at the test runs and reported failures it doesn't look to be caused by the code under merge but more a problem with the test suites not being stable. Can you confirm that, and maybe help the merge underway somehow?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

tnozicka commented Feb 12, 2018

flake: #18569

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

blocked on #18573

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

/retest

1 similar comment
@tnozicka
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor Author

/test gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@tnozicka
Copy link
Contributor Author

/retest

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants