Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all node scheduling for more tests #18835

Conversation

derekwaynecarr
Copy link
Member

fixes #18823

need to take a pass at all tests that are self-scheduling to see if we need to open this list more.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2018
@derekwaynecarr
Copy link
Member Author

need to see if this passes here before merging

cc @liggitt @mfojtik @aveshagarwal @deads2k

@smarterclayton
Copy link
Contributor

Note in #18816 i enabled master scheduling for all kube e2es because it's such a pain otherwise.

@derekwaynecarr
Copy link
Member Author

@smarterclayton - prefer to go with your pr

@derekwaynecarr
Copy link
Member Author

going to update this to align with clayton's pr so we can just take this one piece.

@aveshagarwal
Copy link
Contributor

@derekwaynecarr @jpeeler also has a PR #18843 hope there is no overlap.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2018
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2018
@derekwaynecarr
Copy link
Member Author

@aveshagarwal jeff's merged but had some remnants, this now just removes code no longer needed.

@derekwaynecarr derekwaynecarr added this to the 3.9.0 milestone Mar 5, 2018
@aveshagarwal
Copy link
Contributor

@derekwaynecarr ok sounds good.

@liggitt
Copy link
Contributor

liggitt commented Mar 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link
Member Author

/retest

@derekwaynecarr
Copy link
Member Author

/test unit
/test extended_networking_minimal
/test_extended_conformance_install

@derekwaynecarr
Copy link
Member Author

/test extended_networking_minimal
/test_extended_conformance_install

@derekwaynecarr
Copy link
Member Author

/test extended_networking_minimal

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor

@derekwaynecarr
Copy link
Member Author

flake #18301

/test extended_conformance_install

@derekwaynecarr
Copy link
Member Author

/test extended_conformance_install

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2018

@derekwaynecarr: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_networking_minimal 4dc5c65 link /test extended_networking_minimal

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 40f5a55 into openshift:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sig-storage] HostPath should support existing directory subPath flake
7 participants