-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all node scheduling for more tests #18835
Allow all node scheduling for more tests #18835
Conversation
need to see if this passes here before merging |
Note in #18816 i enabled master scheduling for all kube e2es because it's such a pain otherwise. |
@smarterclayton - prefer to go with your pr |
going to update this to align with clayton's pr so we can just take this one piece. |
@derekwaynecarr @jpeeler also has a PR #18843 hope there is no overlap. |
0f1cd47
to
de92084
Compare
de92084
to
6995c8c
Compare
6995c8c
to
4dc5c65
Compare
@aveshagarwal jeff's merged but had some remnants, this now just removes code no longer needed. |
@derekwaynecarr ok sounds good. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test unit |
/test extended_networking_minimal |
/test extended_networking_minimal |
/retest Please review the full test history for this PR and help us cut down flakes. |
@mrunalp @runcom looks like builds are still failing https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18835/test_pull_request_origin_extended_conformance_install/8476/ (I think the AMI was updated?) |
flake #18301 /test extended_conformance_install |
/test extended_conformance_install |
/test all [submit-queue is verifying that this PR is safe to merge] |
@derekwaynecarr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue. |
fixes #18823
need to take a pass at all tests that are self-scheduling to see if we need to open this list more.