Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] subpath/atomic writer fixes #18954

Merged
merged 6 commits into from
Mar 15, 2018
Merged

[3.7] subpath/atomic writer fixes #18954

merged 6 commits into from
Mar 15, 2018

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Mar 12, 2018

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 12, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 12, 2018
@liggitt liggitt added this to the v3.7 milestone Mar 12, 2018
@liggitt liggitt changed the title subpath/atomic writer fixes [3.7] subpath/atomic writer fixes Mar 12, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Mar 13, 2018

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Mar 13, 2018

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2018
@mfojtik
Copy link
Contributor

mfojtik commented Mar 13, 2018

/retest

Avoid false positives with atomic writer ..<timestamp> directories
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2018
@jsafrane
Copy link
Contributor

/lgtm
for the new commits

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, liggitt, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2018
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@smarterclayton
Copy link
Contributor

/test gcp

@openshift-ci-robot
Copy link

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install 6580d89 link /test extended_conformance_install
ci/openshift-jenkins/end_to_end 6580d89 link /test end_to_end
ci/openshift-jenkins/gcp 6580d89 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Contributor Author

liggitt commented Mar 15, 2018

CI failures are unrelated.

@liggitt liggitt merged commit 282e43f into openshift:release-3.7 Mar 15, 2018
@liggitt
Copy link
Contributor Author

liggitt commented Mar 15, 2018

@smarterclayton merged

@gh1001
Copy link

gh1001 commented Mar 17, 2018

@liggitt are Origin clusters (with SELinux) that only allow users to run the restricted scc impacted by these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants