Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 60632: Add volumemetrics for ISCSI Plugin #19842

Merged
merged 1 commit into from
May 27, 2018

Conversation

humblec
Copy link
Contributor

@humblec humblec commented May 25, 2018

Signed-off-by: Humble Chirammal [email protected]

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2018
@humblec
Copy link
Contributor Author

humblec commented May 25, 2018

/assign @rootfs

@humblec
Copy link
Contributor Author

humblec commented May 25, 2018

/assign @jsafrane

@rootfs
Copy link
Member

rootfs commented May 25, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@humblec
Copy link
Contributor Author

humblec commented May 26, 2018

/retest

@humblec
Copy link
Contributor Author

humblec commented May 26, 2018

/test gcp

1 similar comment
@humblec
Copy link
Contributor Author

humblec commented May 27, 2018

/test gcp

@openshift-merge-robot openshift-merge-robot merged commit faf8c6b into openshift:master May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants