bump(*): #19883
bump(*): #19883
Conversation
* Pin s2i to release-3.10 to exclude `--as-dockerfile` feature * Merge in fix to check assemble-user against allowed UIDS Bug 1582976 Addresses CVE-2018-10843
openshift-ci-robot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adambkaplan Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -47,6 +47,8 @@ import: | |||
| version: master | |||
| - package: github.com/openshift/service-serving-cert-signer | |||
| version: release-3.10 | |||
| - package: github.com/openshift/source-to-image | |||
| version: release-3.10 | |||
There was a problem hiding this comment.
Pin here is to exclude the --as-dockerfile feature @bparees recently added. This is still experimental and we don't want this in Origin until 3.11
| if cpuQuotaPerSecUSec%10000 != 0 { | ||
| cpuQuotaPerSecUSec = ((cpuQuotaPerSecUSec / 10000) + 1) * 10000 | ||
| } | ||
| cpuQuotaPerSecUSec := uint64(c.Resources.CpuQuota*1000000) / c.Resources.CpuPeriod |
There was a problem hiding this comment.
This appears to be another unregistered fork.
|
/hold We can't merge this until we fix the runc fork introduced by #19826 |
openshift-ci-robot
added
the
do-not-merge/hold
|
@adambkaplan: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Duplicates #19888 |
--as-dockerfilefeatureBug 1582976
Addresses CVE-2018-10843