Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 65447: Resolve potential devicePath symlink when MapVolume #20117

Merged

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jun 27, 2018

this is to fix https://bugzilla.redhat.com/show_bug.cgi?id=1594201 for 3.11
I do not know how to test it with containerized kubelet, I assume our e2e will.
@openshift/sig-storage kindly review please ty.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 27, 2018

whoops, I am missing the patch that added EvalSymlinks to nsenter to begin with....

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 27, 2018

/hold
we will pick up EvalSymlinks in the rebase

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2018
@wongma7 wongma7 force-pushed the upstream-mapvolume-symlink branch 2 times, most recently from b26013a to c116295 Compare July 3, 2018 14:27
@wongma7 wongma7 force-pushed the upstream-mapvolume-symlink branch from c116295 to 97205a6 Compare July 3, 2018 15:09
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Jul 3, 2018

/test unit
#20196

@wongma7
Copy link
Contributor Author

wongma7 commented Jul 3, 2018

We need also kubernetes/kubernetes#64426 since we are changing the mount interface & all fake mounters are affected
/hold cancel
/assign @jsafrane
please review, ty

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2018
@jsafrane
Copy link
Contributor

jsafrane commented Jul 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Jul 3, 2018

/assign @smarterclayton
for approval please. Thank you!

@childsb
Copy link
Contributor

childsb commented Jul 24, 2018

/approve

@childsb
Copy link
Contributor

childsb commented Jul 24, 2018

@smarterclayton ping

@childsb
Copy link
Contributor

childsb commented Aug 21, 2018

/approve

@knobunc
Copy link
Contributor

knobunc commented Aug 21, 2018

/lgtm
/approve

Over to you @smarterclayton

@smarterclayton
Copy link
Contributor

smarterclayton commented Aug 21, 2018 via email

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane, knobunc, smarterclayton, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2018
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 22, 2018

/retest

2 similar comments
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 22, 2018

/retest

@wongma7
Copy link
Contributor Author

wongma7 commented Aug 24, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit dc2440c into openshift:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/storage size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants