Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.10] Honor --kubelet-preferred-address-types #20183

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #20146

/assign liggitt

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2018
@jim-minter
Copy link
Contributor

/retest

@jim-minter
Copy link
Contributor

#20206 has fixes for the unit test breakage, which is unrelated

@jim-minter
Copy link
Contributor

/retest

1 similar comment
@jim-minter
Copy link
Contributor

/retest

@jim-minter
Copy link
Contributor

@smarterclayton @liggitt or @enj this is a second cherrypick required by azure, please can you approve it?

@enj
Copy link
Contributor

enj commented Jul 4, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2018
@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 4, 2018 via email

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, openshift-cherrypick-robot, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 83bd74f into openshift:release-3.10 Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants