Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <drop>: vSphere test has race conditions, disable #20231

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

smarterclayton
Copy link
Contributor

Using SetFinalizer(logout) in vsphere code is not safe (since the
connection object has no mutex and finalizers run in other threads).

Disabling the test until resolution of kubernetes/kubernetes#63824 (comment)

Using `SetFinalizer(logout)` in vsphere code is not safe (since the
connection object has no mutex and finalizers run in other threads).

Disabling the test until resolution of kubernetes/kubernetes#63824 (comment)
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 6, 2018
@smarterclayton smarterclayton added lgtm Indicates that a PR is ready to be merged. kind/test-flake Categorizes issue or PR as related to test flakes. queue/critical-fix labels Jul 6, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton smarterclayton merged commit b14326d into openshift:master Jul 6, 2018
@openshift-ci-robot
Copy link

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp 6564042 link /test gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/test-flake Categorizes issue or PR as related to test flakes. lgtm Indicates that a PR is ready to be merged. queue/critical-fix size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants