Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 00000: make delete waits match on UID #20305

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 12, 2018

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2018
return err
}
if status, ok := response.(*metav1.Status); ok && status.Details != nil {
uidMap[kubectlwait.ResourceLocation{Namespace: info.Namespace, Name: info.Name}] = status.Details.UID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does delete never handle multiple resource types? I expected at least group/resource in the key as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does delete never handle multiple resource types? I expected at least group/resource in the key as well

oops. Yep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does delete never handle multiple resource types? I expected at least group/resource in the key as well

fixed and test updated

}
fmt.Printf("#### %v\n", spew.Sdump(deleteResponse))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop debug info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop debug info

fixed

@deads2k deads2k force-pushed the test-04-delete-fix branch 2 times, most recently from 9fbd1d8 to f3b13c3 Compare July 12, 2018 18:11
@deads2k
Copy link
Contributor Author

deads2k commented Jul 12, 2018

upstream here kubernetes/kubernetes#66136

Will rename after green.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 12, 2018

/retest

@liggitt
Copy link
Contributor

liggitt commented Jul 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2018
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 12, 2018

renamed commit

@deads2k
Copy link
Contributor Author

deads2k commented Jul 12, 2018

merging

@deads2k deads2k merged commit 5fa553e into openshift:master Jul 12, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2018

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit 7cca473 link /test unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants