Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick cloud resource sync manager related fixes. #20369

Conversation

aveshagarwal
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2018
@aveshagarwal
Copy link
Contributor Author

[ERROR] [18:02:08+0000] PID 2287: hack/lib/cmd.sh:241: `return "${return_code}"` exited with status 1.
[INFO] [18:02:08+0000] 		Stack Trace: 
[INFO] [18:02:08+0000] 		  1: hack/lib/cmd.sh:241: `return "${return_code}"`
[INFO] [18:02:08+0000] 		  2: hack/verify-upstream-commits.sh:19: os::cmd::expect_success
[INFO] [18:02:08+0000]   Exiting with code 1.
[ERROR] [18:02:08+0000] hack/verify-upstream-commits.sh exited with code 1 after 00h 00m 14s
make: *** [verify-commits] Error 1

Related to commits, looking.

… (initializeModules)

to avoid kubelet getting stuck in retrieving node addresses from a cloudprovider
@aveshagarwal aveshagarwal force-pushed the release-3.10-cloud-resource-sync-manager branch from ec93157 to 0f1103b Compare July 19, 2018 18:44
@derekwaynecarr derekwaynecarr self-assigned this Jul 19, 2018
@aveshagarwal
Copy link
Contributor Author

dont see this test failure related to this pr, so restarting:

/test extended_clusterup

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2018
@openshift-merge-robot openshift-merge-robot merged commit 228b971 into openshift:release-3.10 Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants