Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 66249: fill in normal restmapping info with the legacy guess #20392

Merged
merged 3 commits into from
Jul 26, 2018
Merged

UPSTREAM: 66249: fill in normal restmapping info with the legacy guess #20392

merged 3 commits into from
Jul 26, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 23, 2018

Fixes kubernetes/kubernetes#65718 for us.

/assign @soltysh

/hold

for 1.11.1 rebase.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jul 23, 2018

/retest

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jul 25, 2018

rebase landed

/hold cancel

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 25, 2018
soltysh
soltysh approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Jul 25, 2018

/retest

2 similar comments
@deads2k
Copy link
Contributor Author

deads2k commented Jul 26, 2018

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Jul 26, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 0c4c2ad into openshift:master Jul 26, 2018
@joelanford joelanford mentioned this pull request Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@sttts sttts Awaiting requested review from sttts

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @openshift-ci-robot @soltysh @openshift-merge-robot