-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 66464: Avoid overflowing int64 in RoundUpSize and return error if overflow int #20418
Conversation
…unks of GiB inste...
…ror if overflow int
@openshift/sig-storage please review thank you! |
/lgtm |
/assign @smarterclayton |
/retest |
/assign @mfojtik |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mfojtik, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test end_to_end {"component":"initupload","error":"failed to upload to GCS: could not connect to GCS: dialing: cannot read credentials file: open /data/credentials.json: no such file or directory","level":"fatal","msg":"Failed to initialize job","time":"2018-07-27T16:47:58Z"} |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/refresh |
This fixes/mitigates https://bugzilla.redhat.com/show_bug.cgi?id=1592653
commits 1 & 2 are needed for patching GCE files cleanly. They fix a bug with GCE GiB vs GB and they were cherrypicked into kubernetes 1.11 (and 1.10) as well so there is no harm in doing the same here.
commit 3 is for patching cinder files cleanly. it is arguable whether it's needed or I should have just manually fixed the conflict but It seems harmless to me.
commit 4 is the patch I actually want to cherry-pick